Backport of Reference hashicorp/consul instead of consul for Docker image into release/1.14.x#17918
Merged
nathancoleman merged 3 commits intorelease/1.14.xfrom Jun 28, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/NET-2928-fix-integration-tests/newly-premium-bee
branch
from
9a00ae2 to
ed2fc2d
Compare
hc-github-team-consul-core
force-pushed
the
backport/NET-2928-fix-integration-tests/newly-premium-bee
branch
2 times, most recently
from
73f117f to
ed2fc2d
Compare
github-actions
bot
added
the
type/docs
github-team-consul-core-pr-approver
approved these changes
Jun 27, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
* Reference hashicorp/consul instead of consul for Docker image * Update Make targets that pull consul directly
nathancoleman
deleted the
backport/NET-2928-fix-integration-tests/newly-premium-bee
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17914 to be assessed for backporting due to the inclusion of the label backport/1.14.
🚨
The person who merged in the original PR is:
@nathancoleman
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
consul:latestno longer exists. We should instead referencehashicorp/consul:latest(or whichever other tag we're using).Prior to this PR, our integration tests are broken due to the above (example).
Testing & Reproduction steps
Our own integration tests exercise the modified Dockerfiles. They should pass on this PR.
Links
PR Checklist
Overview of commits